Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Bug/saving #105

Merged
merged 3 commits into from
Dec 9, 2021
Merged

🪲 Bug/saving #105

merged 3 commits into from
Dec 9, 2021

Conversation

AlexandreSajus
Copy link
Contributor

"Save as" now actually saves the .ipyg file instead of just setting the savepath

Default file suffix is set to .ipyg:
image

@AlexandreSajus
Copy link
Contributor Author

"run source code when run button is pressed." fails on Github but succeeds in local. Weird, especially since this has happened on another completely different branch

@MathisFederico
Copy link
Member

"run source code when run button is pressed." fails on Github but succeeds in local. Weird, especially since this has happened on another completely different branch

Yeah yeah I know ..

MathisFederico
MathisFederico previously approved these changes Dec 8, 2021
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this solve #106 ?
If yes, link the issue and merge !

@MathisFederico
Copy link
Member

MathisFederico commented Dec 8, 2021

Does this solve #106 ? If yes, link the issue and merge !

Well a fix to #106 has been merged by #107 (thanks @FabienRoger !), just make it compatible while solving conflicts !

@FabienRoger
Copy link
Contributor

This branch fixes #106 but also another one. I will merge them so that both are fixed.

@MathisFederico MathisFederico merged commit 1930fd0 into master Dec 9, 2021
@MathisFederico MathisFederico deleted the bug/saving branch December 9, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants